[GitHub] [royale-asjs] mjesteve commented on issue #1100: Fix ArrayView not sorted numerically from string fields

[GitBox]

mjesteve commented on issue #1100:
URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818517998


   Hi Harbs, 
   this is the code before the modification:
   
   ```
   org.apache.royale.utils.Language.sortOn = function(arr, names, opt) {
     opt = typeof opt !== 'undefined' ? opt : 0;
     if (org.apache.royale.utils.Language.is(names, Array)) {
       org.apache.royale.utils.Language.sortNames = names;
     } else {
       org.apache.royale.utils.Language.sortNamesOne[0] = names;
       org.apache.royale.utils.Language.sortNames = 
org.apache.royale.utils.Language.sortNamesOne;
     }
     if (org.apache.royale.utils.Language.is(opt, Array)) {
       var /** @type {number} */ opt2 = 0;
       var foreachiter0_target = opt;
       for (var foreachiter0 in foreachiter0_target) 
       {
       var o = foreachiter0_target[foreachiter0];
       {
         opt2 = opt2 | o;
       }}
       
     } else {
       opt2 = ((org.apache.royale.utils.Language._int(opt) == opt) ? 
org.apache.royale.utils.Language._int(opt) : 0) >> 0;
     }
     org.apache.royale.utils.Language.muler = (2 & opt2) > 0 ? -1 : 1;
     var /** @type {Array} */ orig;
     if (opt2 & 8) {
       orig = arr;
       arr = arr.slice();
     }
     if (opt2 & 16) {
       arr.sort(org.apache.royale.utils.Language.compareNumber);
     } else if (opt2 & 1) {
       arr.sort(org.apache.royale.utils.Language.compareStringCaseinsensitive);
     } else {
       arr.sort(org.apache.royale.utils.Language.compareString);
     }
     if (opt2 & 8) {
       return org.apache.royale.utils.Language.getIndexedArray(orig, arr);
     }
     return arr;
   };
   ```
   
   ```
   org.apache.royale.utils.Language.compareNumber = function(a, b) {
     var foreachiter3_target = org.apache.royale.utils.Language.sortNames;
     for (var foreachiter3 in foreachiter3_target) 
     {
     var n = foreachiter3_target[foreachiter3];
     {
       if (a[n] > b[n]) {
         return (org.apache.royale.utils.Language.muler) >> 0;
       } else if (a[n] < b[n]) {
         return (-org.apache.royale.utils.Language.muler) >> 0;
       }
     }}
     
     return 0;
   };
   
   ```
   And this is the code after the modification:
   
   ```
   org.apache.royale.utils.Language.sortOn = function(arr, names, opt) {
     opt = typeof opt !== 'undefined' ? opt : 0;
     if (org.apache.royale.utils.Language.is(names, Array)) {
       org.apache.royale.utils.Language.sortNames = names;
     } else {
       org.apache.royale.utils.Language.sortNamesOne[0] = names;
       org.apache.royale.utils.Language.sortNames = 
org.apache.royale.utils.Language.sortNamesOne;
     }
     if (org.apache.royale.utils.Language.is(opt, Array)) {
       var /** @type {number} */ opt2 = 0;
       var foreachiter0_target = opt;
       for (var foreachiter0 in foreachiter0_target) 
       {
       var o = foreachiter0_target[foreachiter0];
       {
         opt2 = opt2 | o;
       }}
       
     } else {
       opt2 = ((org.apache.royale.utils.Language._int(opt) == opt) ? 
org.apache.royale.utils.Language._int(opt) : 0) >> 0;
     }
     org.apache.royale.utils.Language.muler = (2 & opt2) > 0 ? -1 : 1;
     var /** @type {Array} */ orig;
     if (opt2 & 8) {
       orig = arr;
       arr = arr.slice();
     }
     if (opt2 & 16) {
       arr.sort(org.apache.royale.utils.Language.compareNumber);
     } else if (opt2 & 1) {
       arr.sort(org.apache.royale.utils.Language.compareStringCaseinsensitive);
     } else {
       arr.sort(org.apache.royale.utils.Language.compareString);
     }
     if (opt2 & 8) {
       return org.apache.royale.utils.Language.getIndexedArray(orig, arr);
     }
     return arr;
   };
   ```
   ```
   org.apache.royale.utils.Language.compareNumber = function(a, b) {
     var foreachiter3_target = org.apache.royale.utils.Language.sortNames;
     for (var foreachiter3 in foreachiter3_target) 
     {
     var n = foreachiter3_target[foreachiter3];
     {
       if (Number(a[n]) > Number(b[n])) {
         return (org.apache.royale.utils.Language.muler) >> 0;
       } else if (Number(a[n]) < Number(b[n])) {
         return (-org.apache.royale.utils.Language.muler) >> 0;
       }
     }}
     
     return 0;
   };
   ```
   
   This is what you need to see?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org