[GitHub] [royale-asjs] Harbs commented on issue #1100: Fix ArrayView not sorted numerically from string fields

[GitBox]

Harbs commented on issue #1100:
URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818594564


   Don't have time to test right now, but I'd probably fix it by modifying 
`sortOn` like so:
   
   ````
               if (opt2 & Array.NUMERIC)
               {
                   // Modify a copy in case the original array is being used
                   sortNames = sortNames.slice();
                   var len:Int = sortNames.length;
                   for(var i:int=0;i<len;i++)
                   {
                       sortNames[i] = Number(sortNames[i]);
                   }
                   arr.sort(compareNumber);
   
   ````
   
   You can probably also do something like this:
   
   ````
               if (opt2 & Array.NUMERIC)
               {
                   sortNames = sortNames.map(Number);
                   arr.sort(compareNumber);
   ````
   But the first version is probably more performant.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org