paleolimbot commented on code in PR #1778:
URL: https://github.com/apache/sedona/pull/1778#discussion_r1938181153
##########
spark/common/src/main/java/org/apache/sedona/core/spatialRDD/SpatialRDD.java:
##########
@@ -278,7 +304,7 @@ public void spatialPartitioning(SpatialPartitioner
partitioner) {
/** @deprecated Use spatialPartitioning(SpatialPartitioner partitioner) */
public boolean spatialPartitioning(final List<Envelope> otherGrids) throws
Exception {
- this.partitioner = new FlatGridPartitioner(otherGrids);
+ this.partitioner = new IndexedGridPartitioner(otherGrids);
Review Comment:
> if we think this is important should we un-deprecate it?
That's a great point! I added it here because it's invoked by Python for the
non-unique case, and my test uses it. I think it may be more useful to add a
docstring explaining when it is appropriate to use this mechanism
(partitioning, testing, and your use case are I think all good ones; load
balancing a partitioning scheme for a join is not, which is I think what Jia
was afraid would be the case). The indexed version of the flat grid I think
removes the performance issue with it if that was a concern.
> Is it right to include the overflow partition here?
I think so...if it's not included will rows be removed from the output? I
don't think there's a performance issue with including it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
