james-willis commented on code in PR #1778:
URL: https://github.com/apache/sedona/pull/1778#discussion_r1940012098


##########
spark/common/src/main/java/org/apache/sedona/core/spatialRDD/SpatialRDD.java:
##########
@@ -278,7 +304,7 @@ public void spatialPartitioning(SpatialPartitioner 
partitioner) {
 
   /** @deprecated Use spatialPartitioning(SpatialPartitioner partitioner) */
   public boolean spatialPartitioning(final List<Envelope> otherGrids) throws 
Exception {
-    this.partitioner = new FlatGridPartitioner(otherGrids);
+    this.partitioner = new IndexedGridPartitioner(otherGrids);

Review Comment:
   > if it's not included will rows be removed from the output? 
   
   Correct. best to leave it in



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to