james-willis commented on code in PR #1811: URL: https://github.com/apache/sedona/pull/1811#discussion_r1962317142
########## common/src/main/java/org/apache/sedona/common/geometryObjects/Geography.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sedona.common.geometryObjects; + +import org.locationtech.jts.geom.Geometry; + +public class Geography { + private Geometry geometry; Review Comment: is there any extra overhead to using a Geometry internally? like time or space cost in the constructor. ########## python/sedona/register/java_libs.py: ########## @@ -26,6 +26,7 @@ class SedonaJvmLib(Enum): KNNQuery = "org.apache.sedona.core.spatialOperator.KNNQuery" RangeQuery = "org.apache.sedona.core.spatialOperator.RangeQuery" Envelope = "org.locationtech.jts.geom.Envelope" + Geography = "import org.apache.sedona.common.geometryObjects.Geography" Review Comment: should the word import be here? ########## common/src/main/java/org/apache/sedona/common/Functions.java: ########## @@ -784,6 +785,10 @@ public static byte[] asEWKB(Geometry geometry) { return GeomUtils.getEWKB(geometry); } + public static byte[] geogAsEWKB(Geography geography) { Review Comment: why not call is asEWKB? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
