jiayuasu commented on code in PR #1811: URL: https://github.com/apache/sedona/pull/1811#discussion_r1962420188
########## spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/InferredExpression.scala: ########## @@ -23,7 +23,7 @@ import org.apache.spark.sql.catalyst.InternalRow import org.apache.spark.sql.catalyst.expressions.{Expression, ImplicitCastInputTypes} import org.apache.spark.sql.catalyst.expressions.codegen.CodegenFallback import org.apache.spark.sql.catalyst.util.ArrayData -import org.apache.spark.sql.sedona_sql.UDT.GeometryUDT +import org.apache.spark.sql.sedona_sql.UDT.{GeometryUDT, GeographyUDT} Review Comment: For functions that support both Geometry and Geography, I believe we should overload the functions with Geometry and Geography function. This is not currently supported by `InferredExpression`? @Kontinuation @zhangfengcdt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org