zhangfengcdt commented on PR #2005: URL: https://github.com/apache/sedona/pull/2005#issuecomment-2997725947
> @zhangfengcdt PR definitely isn't fully ready yet, but I want to hear your thoughts. What types of common tests should we include for each function? Originally, I was thinking we have type checking tests (done) and tests for comparing our output to original geopandas function output, but the result of `.buffer()` is too far off for to match geopandas output successfully. Should we drop that type of test entirely or keep that type of test for the methods that can pass it? I guess we have to add tests for manually checking the output. Any other tests we should add? > > As I mentioned in the PR description, I want this PR to flush out all the common tests we use for every method. I think we need both basic tests that manually check the results from the API and the match to geopandas test suits. For the later, we might get some idea from the pandas on spark package, especially how `assertPandasOnSparkEqual` works in pyspark source. For the former, Sedona has a test suit for expression (functions) and we may want to at least cover the cases in there: https://github.com/apache/sedona/blob/master/spark/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
