petern48 commented on PR #2005: URL: https://github.com/apache/sedona/pull/2005#issuecomment-3001267057
For various reasons, none of the built in assert methods work out of the box, even when using parameters like `checkExact` and `check_less_precise`. I did manage to get it to pass by looping through, which we already do [elsewhere in our code](https://github.com/apache/sedona/blob/ebf00cb16cc0e3f4268f9a36331e27e6361bca3c/python/tests/test_base.py#L97-L98), and tuning the tolerance a bit. Personally, I think it's good enough for now. Another reason I'd like to avoid using the pyspark testing functions (e.g `assertPandasOnSparkEqual` and `assertDataFrameEqual`) because they've been removed and added across different version. They're not available until 3.5.0, and we'd have to start using annoying conditional logic like `if pyspark.__version__ >= 4.0.0` use this function, else if use this one, else skip, etc. Cleaner and easier to maintain if we just avoid using them all together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
