paleolimbot commented on PR #10: URL: https://github.com/apache/sedona-db/pull/10#issuecomment-3246937605
Awesome! > How much do we care to drill down? Not that far! The tests are all about correctness and corner cases...here we can stick to the most common cases. Most functions shouldn't need more than one or two benchmarks (one on a simple geometry, which is a benchmark of our per-geometry overhead, and one for complex geometry, which is more a test of the underlying implementation). > I'm not sure how 1. we should make this configurable or 2. to what extent we should make it configurable. No need to make it configurable now, but maybe rename the tables to `_small` and `_large` in case we decide to change those numbers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
