paleolimbot commented on code in PR #10:
URL: https://github.com/apache/sedona-db/pull/10#discussion_r2317263257


##########
python/sedonadb/benchmarks/test_bench_base.py:
##########
@@ -0,0 +1,25 @@
+from sedonadb.testing import DuckDB, PostGIS, SedonaDB
+
+
+class TestBenchBase:
+    def setup_class(self):
+        self.sedonadb = SedonaDB.create_or_skip()
+        self.postgis = PostGIS.create_or_skip()
+        self.duckdb = DuckDB.create_or_skip()
+
+        # Setup tables
+        num_rows = 10000
+        create_points_query = f"CREATE TABLE points AS SELECT 
ST_GeomFromText('POINT(0 0)') AS geom FROM range({num_rows})"

Review Comment:
   It looks like you found `vertices_per_linestring_range`. I use the numbers 
10 ("simple") and 500 ("complex") in the Rust benchmarks, which is sort of 
arbitrary but did the trick of weeding out predicate implementations that 
weren't using a prepared geometry (particularly when one side was a scalar). 
Totally optional!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@sedona.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to