paleolimbot commented on code in PR #67:
URL: https://github.com/apache/sedona-db/pull/67#discussion_r2344723736
##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -290,6 +290,34 @@ def test_st_envelope(eng, geom, expected):
eng.assert_query_result(f"SELECT ST_Envelope({geom_or_null(geom)})",
expected)
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom", "expected"),
+ [
+ # Failing on None for SedonaDB: with datafusion optimizer exception
Review Comment:
I can't spot anything off with the matcher and anybody who types
`ST_FlipCoordinates(NULL)` in SQL is really just being mean...follow up issue
sounds great!
The offending situation might be replicated by:
```rust
let tester =
ScalarUdfTester::new(st_flipcoordinates_udf().into(),
vec![SedonaType::Arrow(DataType:Null))]);
let result = tester.invoke_scalar(ScalarValue::Null).unwrap();
```
...although I'm not actually sure what `result` DataFusion is expecting here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
