jesspav commented on code in PR #67:
URL: https://github.com/apache/sedona-db/pull/67#discussion_r2344577060
##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -290,6 +290,34 @@ def test_st_envelope(eng, geom, expected):
eng.assert_query_result(f"SELECT ST_Envelope({geom_or_null(geom)})",
expected)
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom", "expected"),
+ [
+ # Failing on None for SedonaDB: with datafusion optimizer exception
Review Comment:
`(None,None)` does not work.
Exception:
```
E sedonadb._lib.SedonaError: Optimizer rule 'optimize_projections'
failed
E caused by
E Check optimizer-specific invariants after optimizer rule:
optimize_projections
E caused by
E Internal error: Failed due to a difference in schemas: original
schema: DFSchema { inner: Schema { fields: [Field { name:
"st_flipcoordinates(NULL)", data_type: Null, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }], metadata: {} }, field_qualifiers:
[None], functional_dependencies: FunctionalDependencies { deps: [] } }, new
schema: DFSchema { inner: Schema { fields: [Field { name:
"st_flipcoordinates(NULL)", data_type: Binary, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }], metadata: {} }, field_qualifiers:
[None], functional_dependencies: FunctionalDependencies { deps: [] } }.
E This issue was likely caused by a bug in DataFusion's code. Please
help us to resolve this by filing a bug report in our issue tracker:
https://github.com/apache/datafusion/issues
```
Does that look familiar? I'm not sure how the null geo becomes binary. If
you think this looks related to this change let me know and I'll dig in now.
Otherwise I'll open an issue to track.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
