paleolimbot commented on code in PR #146:
URL: https://github.com/apache/sedona-db/pull/146#discussion_r2376267308
##########
.github/workflows/r.yml:
##########
@@ -88,13 +88,12 @@ jobs:
- uses: r-lib/actions/setup-r-dependencies@v2
with:
+ extra-packages: any::rcmdcheck
needs: check
working-directory: r/sedonadb
- - name: Install R Package
- run: |
- R CMD INSTALL r/sedonadb --preclean
-
- - name: Test R Package
- run: |
- R -e 'library(testthat); test_local("r/sedonadb",
MultiReporter$new(list(CheckReporter$new(), LocationReporter$new())))'
Review Comment:
It might make sense to keep this and add the CMD check version in a separate
workflow that doesn't run whenever somebody touches `rust/**`. I *think* the R
CMD INSTALL version more effectively uses the cache (but if the CMD check
version is still in the ~15 minute range we should totally do that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
