paleolimbot commented on code in PR #146:
URL: https://github.com/apache/sedona-db/pull/146#discussion_r2376734101


##########
.github/workflows/r.yml:
##########
@@ -88,13 +88,12 @@ jobs:
 
       - uses: r-lib/actions/setup-r-dependencies@v2
         with:
+          extra-packages: any::rcmdcheck
           needs: check
           working-directory: r/sedonadb
 
-      - name: Install R Package
-        run: |
-          R CMD INSTALL r/sedonadb --preclean
-
-      - name: Test R Package
-        run: |
-          R -e 'library(testthat); test_local("r/sedonadb", 
MultiReporter$new(list(CheckReporter$new(), LocationReporter$new())))'

Review Comment:
   Let's get CMD check passing in a future PR! As I think you discovered here, 
there's some C file deep in the dependency stack that CMD check objects to (we 
either need to patch the file, remove the file after build, or ignore just that 
specific error).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to