Copilot commented on code in PR #173:
URL: https://github.com/apache/sedona-db/pull/173#discussion_r2399251735
##########
rust/sedona-geoparquet/src/format.rs:
##########
@@ -364,15 +364,21 @@ impl GeoParquetFileSource {
predicate: Option<Arc<dyn PhysicalExpr>>,
) -> Result<Self> {
if let Some(parquet_source) =
inner.as_any().downcast_ref::<ParquetSource>() {
- let mut parquet_source = parquet_source.clone();
+ let parquet_source = parquet_source.clone();
// Extract the predicate from the existing source if it exists so
we can keep a copy of it
let new_predicate = match (parquet_source.predicate().cloned(),
predicate) {
(None, None) => None,
(None, Some(specified_predicate)) => Some(specified_predicate),
(Some(inner_predicate), None) => Some(inner_predicate),
- (Some(_), Some(specified_predicate)) => {
- parquet_source =
parquet_source.with_predicate(specified_predicate.clone());
- Some(specified_predicate)
+ (Some(inner_predicate), Some(specified_predicate)) => {
+ // Sanity check: predicate in `GeoParquetFileSource` is
init
+ // from its inner ParquetSource's predicate, they should be
+ // equivalent.
+ if Arc::ptr_eq(&inner_predicate, &specified_predicate) {
+ Some(inner_predicate)
+ } else {
+ return sedona_internal_err!("Inner predicate should be
equivalent to the predicate in `GeoParqeutFileSource`");
Review Comment:
There's a typo in the error message: 'GeoParqeutFileSource' should be
'GeoParquetFileSource'.
```suggestion
return sedona_internal_err!("Inner predicate should
be equivalent to the predicate in `GeoParquetFileSource`");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
