2010YOUY01 commented on code in PR #173:
URL: https://github.com/apache/sedona-db/pull/173#discussion_r2403988412
##########
rust/sedona-geoparquet/src/file_opener.rs:
##########
@@ -176,7 +218,10 @@ fn filter_access_plan_using_geoparquet_covering(
// Evaluate predicate!
if !spatial_filter.evaluate(&row_group_geo_stats) {
+ metrics.row_groups_spatial_pruned.add(1);
access_plan.skip(i);
Review Comment:
I think it's better not to count row groups skipped in the previous file
pruning stage. If there is a more fine-grained pruning (parquet page level) to
implement in the future, we might need some redundant calculations for related
metrics when pruning the files.
I have added more comment to clarify it in
[3df3a0e](https://github.com/apache/sedona-db/pull/173/commits/3df3a0e7bce9912c52671deca35e9825fc82441d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
