jiayuasu commented on code in PR #2380:
URL: https://github.com/apache/sedona/pull/2380#discussion_r2431272858
##########
pom.xml:
##########
@@ -416,6 +421,10 @@
<id>Spark Packages</id>
<url>https://repos.spark-packages.org/</url>
</repository>
+ <repository>
+ <id>jitpack.io</id>
+ <url>https://jitpack.io</url>
+ </repository>
Review Comment:
```suggestion
```
##########
common/pom.xml:
##########
@@ -120,6 +120,11 @@
<artifactId>janino</artifactId>
<version>${janino-version}</version>
</dependency>
+ <dependency>
+ <groupId>org.datasyslab</groupId>
+ <artifactId>campskeleton</artifactId>
+ <version>0.0.2-20251014</version>
Review Comment:
```suggestion
```
##########
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala:
##########
Review Comment:
1. Please add the 2 functions to preserve SRID test suite
2. Please also implement these functions in Scala DataFrame APIs, and Python
DataFrame APIs.
3. Please also port them to Snowflake and Flink.
To test the functions in Snowflake, please create a PR against this repo:
https://github.com/wherobots/sedona-cloud-vendor-tester
##########
python/Pipfile:
##########
@@ -0,0 +1,36 @@
+[[source]]
Review Comment:
please remove the pipfile. Our Python package management has been moved to UV
##########
pom.xml:
##########
@@ -376,6 +376,11 @@
<version>4.11.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.twak</groupId>
+ <artifactId>campskeleton</artifactId>
+ <version>0.0.1</version>
Review Comment:
```suggestion
<groupId>org.datasyslab</groupId>
<artifactId>campskeleton</artifactId>
<version>0.0.2-20251014</version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
