jiayuasu commented on code in PR #2380:
URL: https://github.com/apache/sedona/pull/2380#discussion_r2433477548
##########
snowflake/src/main/java/org/apache/sedona/snowflake/snowsql/UDFsV2.java:
##########
@@ -232,6 +232,24 @@ public static double ST_Azimuth(String left, String right)
{
return Functions.azimuth(GeometrySerde.deserGeoJson(left),
GeometrySerde.deserGeoJson(right));
}
+ @UDFAnnotations.ParamMeta(
Review Comment:
there is no test for Snowflake functions
##########
docs/api/sql/Function.md:
##########
@@ -296,6 +296,48 @@ Output:
0.19739555984988044
```
+## ST_ApproximateMedialAxis
+
+Introduction: Computes an approximate medial axis of a polygonal geometry. The
medial axis is a representation of the "centerline" or "skeleton" of the
polygon. This function first computes the straight skeleton and then prunes
insignificant branches to produce a cleaner result.
Review Comment:
no docs for Snowflake and Flink functions
##########
python/sedona/spark/sql/st_functions.py:
##########
@@ -295,6 +295,27 @@ def ST_Azimuth(point_a: ColumnOrName, point_b:
ColumnOrName) -> Column:
return _call_st_function("ST_Azimuth", (point_a, point_b))
+@validate_argument_types
+def ST_ApproximateMedialAxis(
Review Comment:
no tests for these 2 functions
##########
flink/src/main/java/org/apache/sedona/flink/expressions/Functions.java:
##########
@@ -100,6 +100,24 @@ public Double eval(
}
}
+ public static class ST_ApproximateMedialAxis extends ScalarFunction {
Review Comment:
no tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
