Abeeujah commented on code in PR #229:
URL: https://github.com/apache/sedona-db/pull/229#discussion_r2442543961
##########
c/sedona-geos/benches/geos-functions.rs:
##########
@@ -295,6 +295,20 @@ fn criterion_benchmark(c: &mut Criterion) {
"st_overlaps",
ArrayScalar(Polygon(10), Polygon(500)),
);
+ benchmark::scalar(
+ c,
+ &f,
+ "geos",
+ "st_isvalid",
+ ArrayScalar(Polygon(10), Polygon(10)),
Review Comment:
I guess I should pay more attention, Is there like a way I could catch
subtle errors like these before pushing? My current checks include, tests
passing and pre-commit hook not failing
##########
c/sedona-geos/benches/geos-functions.rs:
##########
@@ -295,6 +295,20 @@ fn criterion_benchmark(c: &mut Criterion) {
"st_overlaps",
ArrayScalar(Polygon(10), Polygon(500)),
);
+ benchmark::scalar(
+ c,
+ &f,
+ "geos",
+ "st_isvalid",
+ ArrayScalar(Polygon(10), Polygon(10)),
+ );
+ benchmark::scalar(
+ c,
+ &f,
+ "geos",
+ "st_isvalid",
+ ArrayScalar(Polygon(10), Polygon(500)),
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
