petern48 commented on code in PR #229:
URL: https://github.com/apache/sedona-db/pull/229#discussion_r2442521972
##########
c/sedona-geos/benches/geos-functions.rs:
##########
@@ -295,6 +295,20 @@ fn criterion_benchmark(c: &mut Criterion) {
"st_overlaps",
ArrayScalar(Polygon(10), Polygon(500)),
);
+ benchmark::scalar(
+ c,
+ &f,
+ "geos",
+ "st_isvalid",
+ ArrayScalar(Polygon(10), Polygon(10)),
Review Comment:
```suggestion
Polygon(10),
```
These are like arguments to the function, since is_valid only takes one
geometry, the value here is just a single Polygon. You can see `st_centroid`
above as an example.
##########
c/sedona-geos/benches/geos-functions.rs:
##########
@@ -295,6 +295,20 @@ fn criterion_benchmark(c: &mut Criterion) {
"st_overlaps",
ArrayScalar(Polygon(10), Polygon(500)),
);
+ benchmark::scalar(
+ c,
+ &f,
+ "geos",
+ "st_isvalid",
+ ArrayScalar(Polygon(10), Polygon(10)),
Review Comment:
```suggestion
Polygon(10),
```
These are like arguments to the function, since is_valid only takes one
geometry, the value here is just a single Polygon. You can see `st_centroid`
above as an example. This should fix the CI failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
