radekaadek commented on PR #2452:
URL: https://github.com/apache/sedona/pull/2452#issuecomment-3476385477
I have added some tests for the module and made the functions use the custom
serializer.
I still don't know how to verify that the functions in the module are
actually using the custom serializer, so I would appreciate it if someone could
help me with that.
I also noticed that all tests are initialized with the `initialize` method:
```
static void initialize(boolean enableWebUI) {
env =
enableWebUI
? StreamExecutionEnvironment.createLocalEnvironmentWithWebUI(new
Configuration())
: StreamExecutionEnvironment.getExecutionEnvironment();
EnvironmentSettings settings =
EnvironmentSettings.newInstance().inStreamingMode().build();
tableEnv = SedonaContext.create(env, StreamTableEnvironment.create(env,
settings));
}
```
It occurred to me that the module could reuse most, if not all, of the test
cases if this method were modified to something like this:
```
static void initialize(boolean enableWebUI) {
env =
enableWebUI
? StreamExecutionEnvironment.createLocalEnvironmentWithWebUI(new
Configuration())
: StreamExecutionEnvironment.getExecutionEnvironment();
EnvironmentSettings settings =
EnvironmentSettings.newInstance().inStreamingMode().build();
tableEnv = StreamTableEnvironment.create(env, settings);
tableEnv.executeSql("LOAD MODULE sedona");
}
```
This would require some refactoring, but let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
