radekaadek commented on PR #2452:
URL: https://github.com/apache/sedona/pull/2452#issuecomment-3478097722
@jiayuasu I solved the issue by making the serializer make some files on my
machine, and it did, but I don't know how you would like see it actually being
tested in unit tests.
I also found that I had missed the `Geometry[]` type and have added it too.
I have not noticed an error appeared in the CI that looks like this:
```
testTableToDS(org.apache.sedona.flink.AdapterTest) Time elapsed: 0.889 sec
<<< ERROR!
org.apache.flink.table.api.ValidationException: Data type
'RAW('java.lang.Object', '...')' does not support an output conversion to class
'org.locationtech.jts.geom.Geometry'.
```
and I don't know if where it's coming from.
After implementing the `Geometry[]` serializer I also noticed more errors:
```
testDump(org.apache.sedona.flink.FunctionTest) Time elapsed: 0.006 sec <<<
ERROR!
org.apache.flink.table.api.ValidationException: Could not extract a valid
type inference for function class
'org.apache.sedona.flink.expressions.Functions$ST_Dump'. Please check for
implementation mistakes and/or provide a corresponding hint.
```
The rest of the tests that are currently failing all seem to be connected to
the `Geometry[]` type:
```
Tests in error:
AdapterTest.testTableToDS:51 » Validation Data type
'RAW('java.lang.Object', '...
FunctionTest.testCollectWithArray:277->TestBase.first:464 » Runtime Failed
to ...
FunctionTest.testDump:378 » Validation Could not extract a valid type
inferenc...
FunctionTest.testDumpPoints:387 » Validation Could not extract a valid
type in...
FunctionTest.testH3ToGeom:2088 » Validation SQL validation failed. An
error oc...
FunctionTest.testLineSegments:1632 » Validation Could not extract a valid
type...
FunctionTest.testMakeLine:1668->TestBase.first:464 » Runtime Failed to
fetch n...
FunctionTest.testMakePolygonWithHoles:1722->TestBase.first:464 » Runtime
Faile...
FunctionTest.testS2ToGeom:2009 » Validation SQL validation failed. An
error oc...
FunctionTest.testSubdivide:1936 » Validation Could not extract a valid
type in...
FunctionTest.testUnionArrayVariant:532->TestBase.first:464 » Runtime
Failed to...
```
The `Geometry[]` class is never added in
`~/prg/sedona/flink/src/main/java/org/apache/sedona/flink/SedonaContext.java`
and it's a different type from `GeometryCollection`, and this is probably the
reason why I'm seeing all of these errors. Was it ever verified that
`Geometry[]` is also properly registered and serialized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
