petern48 commented on PR #2486: URL: https://github.com/apache/sedona/pull/2486#issuecomment-3515051863
I also noticed this is a duplicate test https://github.com/apache/sedona/blob/762d6f85004c17b3bafef73dc3bb65a3a058e38d/python/tests/geopandas/test_geoseries.py#L1934C9-L1935 Could you either delete that one, or replace it with the `test_intersection_all` you created? Once you do that, you'll see the actual test you wrote fail. You'll need to implement `intersection_all` in `base.py` and add documentation following this step, from the [geopandas EPIC issue](https://github.com/apache/sedona/issues/2230) instructions ``` Add documentation under the base.py implementation by copy and pasting from geopandas docstrings. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
