Subham-KRLX commented on code in PR #2486:
URL: https://github.com/apache/sedona/pull/2486#discussion_r2512951244
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -857,6 +857,22 @@ def test_union_all(self):
gpd_result = gpd.GeoSeries([]).union_all()
self.check_geom_equals(sgpd_result, gpd_result)
+ def test_intersection_all(self):
+ if parse_version(gpd.__version__) < parse_version("1.1.0"):
+ pytest.skip("geopandas intersection_all requires version 1.1.0 or
higher")
+
+ # Intersection all the valid geometries
+ # Neither our nor geopandas' implementation supports invalid geometries
+ lst = [g for geom in self.geoms for g in geom if g.is_valid]
Review Comment:
I will make the changes shortly as you suggested to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
