paleolimbot commented on code in PR #542:
URL: https://github.com/apache/sedona-db/pull/542#discussion_r2721817797
##########
rust/sedona-spatial-join/src/exec.rs:
##########
@@ -178,6 +180,7 @@ impl SpatialJoinExec {
filter.as_ref(),
converted_from_hash_join,
)?;
+ let seed = fastrand::u64(0..0xFFFF);
Review Comment:
No need to do this here, but should this be configurable in some way or
logged so we can reproduce failures?
##########
rust/sedona-spatial-join/Cargo.toml:
##########
@@ -66,6 +66,7 @@ geo-index = { workspace = true }
geos = { workspace = true }
float_next_after = { workspace = true }
fastrand = { workspace = true }
+log = { workspace = true }
Review Comment:
Are `log` and `env_logger` doing the same thing or do we need both of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
