Kontinuation commented on code in PR #542:
URL: https://github.com/apache/sedona-db/pull/542#discussion_r2726691050
##########
rust/sedona-spatial-join/src/exec.rs:
##########
@@ -178,6 +180,7 @@ impl SpatialJoinExec {
filter.as_ref(),
converted_from_hash_join,
)?;
+ let seed = fastrand::u64(0..0xFFFF);
Review Comment:
I have added an option `sedona.spatial_join.debug.random_seed` for setting
the random seed; also the seed is printed in debug log.
##########
rust/sedona-spatial-join/Cargo.toml:
##########
@@ -66,6 +66,7 @@ geo-index = { workspace = true }
geos = { workspace = true }
float_next_after = { workspace = true }
fastrand = { workspace = true }
+log = { workspace = true }
Review Comment:
We need both. `log` is the logging facade, `env_logger` is the logging
implementation we actually use.
Reference: https://docs.rs/log/latest/log/#available-logging-implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
