2010YOUY01 commented on PR #580: URL: https://github.com/apache/sedona-db/pull/580#issuecomment-3882020292
Yes that sounds good. Here is some additional information: my final goal is to have an easy way to reproduce the full CI locally, so for small fixes we don’t have to go back and forth checking the GitHub CI runner status. I usually use plain shell scripts for this purpose, as I find them much more flexible than pre-commit configuration files. How about maintaining CI jobs like: ``` cargo-fmt.sh cargo-clippy.sh test.sh ``` Each one can support different options, for example: ``` ./cargo-clippy.sh # check only ./cargo-clippy.sh --fix # auto-fix and then check ./test.sh --fast # quick tests, finish in minutes ./test.sh # full test suite, takes longer ``` Then local CI scripts, GitHub CI configuration, and pre-commit hooks can all call these shared scripts, while still allowing us to customize our local development workflow based on personal preferences. I’m trying to set this up and hopefully sync it with upstream later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
