Kontinuation commented on PR #562: URL: https://github.com/apache/sedona-db/pull/562#issuecomment-3889499099
I need to clarity that this PR does not change the behavior of filter pushdown for KNN joins. The original problems with KNN joins remain the same, and users still need to use barriers to explicitly workaround that problem. This PR mainly fixes the correctness of plan properties of SpatialJoinExec, and avoid breaking the plan property requirements during the physical plan -> physical plan transformation, which may result in physical plan sanity check failures or silently producing incorrect results. The optimization rules for merging filter into Join node and converting Join nodes to SpatialJoinPlanNode all happen after DataFusion's builtin optimization passes, so filter pushdown still behave the same as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
