paleolimbot commented on PR #562:
URL: https://github.com/apache/sedona-db/pull/562#issuecomment-3891576204

   > I need to clarity that this PR does not change the behavior of filter 
pushdown for KNN joins. The original problems with KNN joins remain the same, 
and users still need to use barriers to explicitly workaround that problem.
   
   Agreed, but we can now perhaps improve the predictability of this by placing 
the logical optimizer rule first (or a variant of it that only transforms KNN 
joins to allow DataFusion's optimizer rules to effectively optimize non-KNN 
joins before hitting our optimizer rule). Creating KNN joins explicitly using 
an R/Python DataFrame API would also work. Can definitely be a follow up (I 
opened #605).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to