Copilot commented on code in PR #2681:
URL: https://github.com/apache/sedona/pull/2681#discussion_r2882742000


##########
docs/api/sql/Predicates/ST_Relate.md:
##########
@@ -21,6 +21,9 @@
 
 Introduction: The first variant of the function computes and returns the 
[Dimensionally Extended 9-Intersection Model 
(DE-9IM)](https://en.wikipedia.org/wiki/DE-9IM) matrix string representing the 
spatial relationship between the two input geometry objects.
 
+![ST_Relate returning true](../../../image/ST_Relate/ST_Relate_true.svg 
"ST_Relate returning true")
+![ST_Relate returning false](../../../image/ST_Relate/ST_Relate_false.svg 
"ST_Relate returning false")
+

Review Comment:
   The diagrams shown here depict the boolean-pattern overload (as indicated by 
the SVG title `ST_Relate(A, B, '…')` and TRUE/FALSE badges), but they’re 
inserted immediately after the paragraph describing the *first* overload that 
returns a DE-9IM `String`. This placement (and the “returning true/false” 
wording) is misleading given the surrounding text and the page’s `Return type: 
String` section. Consider moving the images below the paragraph introducing the 
second overload (or adding a short sentence clarifying they illustrate the 
pattern-matching overload), and adjusting alt/title text accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to