Copilot commented on code in PR #2681: URL: https://github.com/apache/sedona/pull/2681#discussion_r2882781931
########## docs/api/snowflake/vector-data/Predicates/ST_Relate.md: ########## @@ -23,6 +23,9 @@ Introduction: The first variant of the function computes and returns the [Dimens The second variant of the function evaluates whether the two input geometries satisfy a specific spatial relationship defined by the provided `intersectionMatrix` pattern. + + + Review Comment: The newly added diagrams/alt text describe ST_Relate “returning true/false”, but this page still states `Return type: String` even though the second overload (`ST_Relate(…, intersectionMatrix)`) returns a boolean (the example output below is `true`). Please update the return type section to reflect both overloads (e.g., String for the 2-arg variant and Boolean for the 3-arg variant) and/or adjust the diagram captions to explicitly tie them to the boolean-pattern overload. ########## docs/api/sql/Predicates/ST_Relate.md: ########## @@ -23,6 +23,9 @@ Introduction: The first variant of the function computes and returns the [Dimens The second variant of the function evaluates whether the two input geometries satisfy a specific spatial relationship defined by the provided `intersectionMatrix` pattern. + + + Review Comment: The newly added diagrams/alt text describe ST_Relate “returning true/false”, but this page still states `Return type: String` even though the second overload (`ST_Relate(…, intersectionMatrix)`) returns a boolean (the example output below is `true`). Please update the return type section to reflect both overloads (e.g., String for the 2-arg variant and Boolean for the 3-arg variant) and/or adjust the diagram captions to explicitly tie them to the boolean-pattern overload. ########## docs/api/flink/Predicates/ST_Relate.md: ########## @@ -23,6 +23,9 @@ Introduction: The first variant of the function computes and returns the [Dimens The second variant of the function evaluates whether the two input geometries satisfy a specific spatial relationship defined by the provided `intersectionMatrix` pattern. + + + Review Comment: The newly added diagrams/alt text describe ST_Relate “returning true/false”, but this page still states `Return type: String` even though the second overload (`ST_Relate(…, intersectionMatrix)`) returns a boolean (the example output below is `true`). Please update the return type section to reflect both overloads (e.g., String for the 2-arg variant and Boolean for the 3-arg variant) and/or adjust the diagram captions to explicitly tie them to the boolean-pattern overload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
