jiayuasu commented on code in PR #2726:
URL: https://github.com/apache/sedona/pull/2726#discussion_r2921208970
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -1214,6 +1254,15 @@ def test_distance(self):
)
self.check_pd_series_equal(sgpd_result, gpd_result)
+ def test_frechet_distance(self):
+ pass
+
+ def test_hausdorff_distance(self):
+ pass
+
+ def test_geom_equals(self):
+ pass
+
Review Comment:
Removed the stub in 546297d.
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -977,7 +999,15 @@ def test_line_merge(self):
self.check_sgpd_equals_gpd(sgpd_result, gpd_result)
def test_unary_union(self):
- pass
+ lst = [g for geom in self.geoms for g in geom if g.is_valid]
+ with pytest.warns(FutureWarning, match="unary_union"):
+ sgpd_result = GeoSeries(lst).unary_union
+ import warnings
+
+ with warnings.catch_warnings():
+ warnings.simplefilter("ignore", FutureWarning)
+ gpd_result = gpd.GeoSeries(lst).unary_union
Review Comment:
Moved to module scope in 546297d.
##########
python/sedona/spark/geopandas/geoseries.py:
##########
@@ -984,12 +981,24 @@ def convex_hull(self) -> "GeoSeries":
)
def delaunay_triangles(self, tolerance=0.0, only_edges=False):
- # Implementation of the abstract method.
- raise NotImplementedError("This method is not implemented yet.")
+ spark_expr = stf.ST_DelaunayTriangles(
+ self.spark.column, tolerance, int(only_edges)
+ )
+ return self._query_geometry_column(
+ spark_expr,
+ returns_geom=True,
+ )
def voronoi_polygons(self, tolerance=0.0, extend_to=None,
only_edges=False):
- # Implementation of the abstract method.
- raise NotImplementedError("This method is not implemented yet.")
+ if only_edges:
+ raise NotImplementedError(
+ "Sedona does not support only_edges=True for voronoi_polygons."
+ )
+ spark_expr = stf.ST_VoronoiPolygons(self.spark.column, tolerance,
extend_to)
Review Comment:
Now raises `NotImplementedError` when `extend_to is not None`. Fixed in
546297d.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
