jiayuasu commented on code in PR #2726:
URL: https://github.com/apache/sedona/pull/2726#discussion_r2921570226
##########
python/sedona/spark/geopandas/base.py:
##########
@@ -1337,9 +1429,35 @@ def line_merge(self, directed=False):
"""
return _delegate_to_geometry_column("line_merge", self, directed)
- # @property
- # def unary_union(self):
- # raise NotImplementedError("This method is not implemented yet.")
+ @property
+ def unary_union(self):
+ """Returns a geometry containing the union of all geometries in the
+ ``GeoSeries``.
+
+ .. deprecated::
+ The ``unary_union`` attribute is deprecated. Use
+ :meth:`union_all` instead.
Review Comment:
Fixed in 389ec26. Replaced `.. deprecated::` directive with plain text to
avoid Sphinx version argument requirement.
##########
python/sedona/spark/geopandas/base.py:
##########
@@ -1502,6 +1620,36 @@ def crosses(self, other, align=None) -> ps.Series:
"""
return _delegate_to_geometry_column("crosses", self, other, align)
+ def disjoint(self, other, align=None):
+ """Returns a ``Series`` of ``dtype('bool')`` with value ``True`` for
+ each aligned geometry that is disjoint from `other`.
+
+ An object is said to be disjoint from `other` if its
+ `boundary` and `interior` does not intersect at all with those of the
+ other.
Review Comment:
Fixed in 389ec26.
##########
python/sedona/spark/geopandas/geoseries.py:
##########
@@ -1203,8 +1222,17 @@ def crosses(self, other, align=None) -> pspd.Series:
return _to_bool(result)
def disjoint(self, other, align=None):
Review Comment:
Fixed in 389ec26.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
