ajaypadwal73 opened a new pull request, #1023: URL: https://github.com/apache/sedona-db/pull/1023
## Summary - Adds optional `min_level`, `max_level`, `max_cells` positional args to `S2_CoveringCellIds`, matching BigQuery's S2 covering signature. - Adds NULL-argument overloads so `S2_CoveringCellIds` returns NULL (rather than failing to resolve) when any parameter is a literal NULL. - Documents the new parameters and defaults (`min_level=0`, `max_level=30`, `max_cells=8`, unchanged from prior hardcoded behavior). Closes #920 ## Known blocker This depends on a corresponding change in the `s2geography` submodule (`coverings.cc`/`coverings.h`/C ABI) that is currently only committed **locally** — I don't have push access to `paleolimbot/s2geography` and no fork exists yet. CI will fail to resolve the submodule ref until that change lands upstream (or in a fork) and the submodule pointer here is updated to a real, published commit. @paleolimbot mentioned in the issue they'd handle the upstream s2geography change — flagging so this PR isn't merged until that's resolved. ## Test plan - [x] Rust unit test (`covering_cell_ids_return_type`) covers return-type resolution for all arg-count/NULL-position combinations. - [x] Python test exercises the 4-arg form end-to-end (`test_s2_coveringcellids_parameters`). - [ ] CI submodule checkout will fail until the s2geography-side change is published (see blocker above). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
