paleolimbot commented on code in PR #1023:
URL: https://github.com/apache/sedona-db/pull/1023#discussion_r3592410353
##########
docs/reference/sql/s2_coveringcellids.qmd:
##########
@@ -21,6 +21,33 @@ description: Returns an array of S2 cell IDs that cover the
given geography.
kernels:
- returns: array
args: [geography]
+ - returns: array
+ args:
+ - geography
+ - name: min_level
+ type: int64
+ description: Minimum S2 cell level to return. Must be between 0 and 30.
Defaults to 0.
Review Comment:
You only need to include the description once per named parameter (the docs
generator will figure it out)
##########
c/sedona-s2geography/src/kernels.rs:
##########
@@ -31,6 +31,14 @@ use sedona_schema::{
use crate::{s2geog_check, s2geography_c_bindgen::*};
+fn covering_cell_ids_type() -> SedonaType {
+ SedonaType::Arrow(DataType::List(Arc::new(arrow_schema::Field::new(
+ "item",
+ DataType::Int64,
+ true,
+ ))))
Review Comment:
I think `DataType::new_list()` (or something similar) is a more canonical
way to create lists (avoids hard-coding the "item" name)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
