jiayuasu opened a new pull request, #1188:
URL: https://github.com/apache/sedona-db/pull/1188

   ## What changes are included in this PR?
   
   Wheel tests currently suppress pytest's exit code, continue building the 
remaining wheels, upload artifacts, and report the failure later through a 
`.test_failed` marker. This change makes test failures propagate directly from 
pytest to cibuildwheel on every platform.
   
   Specifically, it:
   
   - runs `python -m pytest` directly so a failed test stops cibuildwheel 
immediately
   - explicitly exits with `$LASTEXITCODE` after the Windows build script so 
the cibuildwheel status is preserved across the PowerShell invocation
   - removes marker creation, cleanup, and final marker checks
   - retains the `always()` vcpkg cache-save steps, allowing binaries produced 
before a failure to be reused on a cache miss, while leaving wheel artifact 
uploads success-only
   - restores the default success gate for the expr, zarr, geopandas, and 
nightly upload jobs so they cannot consume or publish a partial core wheel set
   
   ## Why are the changes needed?
   
   The marker approach deliberately returns success to cibuildwheel, so a 
failure can take tens of minutes to surface while later Python versions 
continue building. It also requires platform-specific coordination across host, 
container, and PowerShell boundaries. Returning pytest's real status is simpler 
and prevents failed or incomplete builds from producing wheel artifacts or 
starting dependent jobs.
   
   ## Are these changes tested?
   
   - [Full fork 
matrix](https://github.com/jiayuasu/sedona-db/actions/runs/32626533696): all 
five core wheel jobs passed on Windows x86_64, macOS arm64/amd64, and Linux 
x86_64/arm64.
   - [Intentional failure 
run](https://github.com/jiayuasu/sedona-db/actions/runs/32629325994): an 
injected pytest failure returned code 1 through cibuildwheel; the wheel 
artifact step was skipped, the run produced zero artifacts, and expr, zarr, 
geopandas, and nightly upload were all skipped.
   - workflow YAML parse and `git diff --check`
   
   ## Are there any user-facing changes?
   
   No. This only changes wheel CI failure handling.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to