jiayuasu commented on PR #1195: URL: https://github.com/apache/sedona-db/pull/1195#issuecomment-5506308819
Thanks for the review. Pushed `888a8dbd9` with everything addressed; the decisions in one place: - **Temporal scalars are handled here rather than deferred.** A new `_temporal` module picks a lossless Arrow unit for `numpy.datetime64`/`timedelta64` (rejecting ambiguous or sub-nanosecond units the way pandas does, with an overflow check), keeps nanoseconds for `pandas.Timestamp`/`Timedelta` (including zone-aware timestamps), and assigns `NaT` as a datetime missing value. The "temporarily rejected" note is gone from the README. Duration arithmetic and temporal group keys come with the arithmetic and dissolve follow-ups. - **A `Series` now survives assignments that only add columns**, so one captured geometry can supply several derived columns. Replacing a column or filtering still invalidates earlier reads. - **`shapely>=2` is a declared dependency**; the Shapely 1.x compatibility code is gone. - **Upstream:** #1214 (what `lit()` could resolve on its own: GeoArrow scalars with their edge type, and the missing/temporal scalar cases) and #1215 (WKB import rejecting LargeBinary storage). The wrapper keeps its workarounds until those land so it stays usable on 0.4.1. 92 tests, run with warnings promoted to errors against both current main and the released 0.4.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
