jiayuasu commented on PR #1195: URL: https://github.com/apache/sedona-db/pull/1195#issuecomment-5549978636
Thanks! On the temporal internals: the compatibility tests exercise them end to end (assignment, then materialization), but nothing pinned the helper itself, so `0b14e05a5` adds `tests/test_temporal.py` testing `normalize_temporal_scalar` and `nat_scalar` directly. It covers the unit table (Arrow-native units kept; week/day/hour/minute and datetime year/month converted exactly to seconds, including values outside the nanosecond range; exact sub-nanosecond values narrowed to nanoseconds), the zone-aware Timestamp path, every missing-value form (numpy NaT, `pd.NaT`, and the INT64_MIN sentinel as duration and timestamp), Arrow scalar pass-through, and the error classes for ambiguous units, lossy values, and overflow. That last one runs under both NumPy 2.3 and 2.5, which differ only in which layer raises the `OverflowError`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
