[
https://issues.apache.org/jira/browse/SENTRY-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328289#comment-15328289
]
Colin Patrick McCabe commented on SENTRY-1324:
----------------------------------------------
Nice work!
{code}
public class TestNotificationLog extends
AbstractMetastoreTestWithStaticConfiguration {
{code}
Hmm. Would it make more sense to call this {{TestHmsNoticationLog}} to
emphasize that it's testing the Hive notification log? Or is that clear already
{{Assert.assertEquals}}: might make sense to static import this and other stuff
in {{Assert}}, to shorten some long lines?
{{CurrentNotificationEventId NId}}: should we verify that this is monotonically
increasing?
> Add sentry specific test cases to use NotificationLog
> -----------------------------------------------------
>
> Key: SENTRY-1324
> URL: https://issues.apache.org/jira/browse/SENTRY-1324
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
> Reporter: Sravya Tirukkovalur
> Assignee: Sravya Tirukkovalur
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1324.0.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
