[ https://issues.apache.org/jira/browse/SENTRY-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330859#comment-15330859 ]
Sravya Tirukkovalur commented on SENTRY-1324: --------------------------------------------- We should be able to commit this without having to move hive dependency to >= 1.2.0. Also, as you can see in the tests, there is some information missing in the notification event log. Some of these can be obtained by doing another getTable()/getDatabase() call to HMS. But some of these are permanently lost if we do not capture them during the event. For example, for the command "Alter table location", we need the old location in Sentry to make sure we revoke the table related grants on this old location. We cannot jut delete all paths corresponding to this table in Sentry, as there might be some partitions which point to this table and hence <Obj,Path> is a many-many in Sentry. Also, capturing the location would allow to see have the entire context in notification log entry without having to do another HMS RPC to get missing information. Hence, I propose adding additional info in the notification log entry. Thoughts? > Add sentry specific test cases to use NotificationLog > ----------------------------------------------------- > > Key: SENTRY-1324 > URL: https://issues.apache.org/jira/browse/SENTRY-1324 > Project: Sentry > Issue Type: Sub-task > Components: Hdfs Plugin > Reporter: Sravya Tirukkovalur > Assignee: Sravya Tirukkovalur > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1324.0.patch, SENTRY-1324.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)