[ 
https://issues.apache.org/jira/browse/SENTRY-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206452#comment-16206452
 ] 

Sergio Peña commented on SENTRY-1992:
-------------------------------------

The serviceName is obtained from the following configuration when 
SentryKafkaAuthorizer.configure() is called:

{noformat}
  <property>
    <name>sentry.kafka.service.instance</name>
    <value></value>
  </property>
{noformat}

The componentType is only a string constant defined as 'kafka'. I believed this 
is just the service type that the Sentry server will use to detect the type of 
requests (not sure yet).

Why do you need the componentType configurable?
Where do you think we need to validate these parameters? Should we throw an 
error if not set?

> Improve parameter handling for SentryGenericProviderBackend
> -----------------------------------------------------------
>
>                 Key: SENTRY-1992
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1992
>             Project: Sentry
>          Issue Type: Improvement
>            Reporter: Mano Kovacs
>
> {{SentryGenericProviderBackend}} uses {{componentType}} and {{serviceName}} 
> for sentry-service request but does not validate if it set, nor takes it from 
> the configuration. That makes less modular to configure bindings.
> Proposing validation of the parameters and fallback for configuration entries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to