[
https://issues.apache.org/jira/browse/SENTRY-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220566#comment-16220566
]
Sergio Peña commented on SENTRY-1992:
-------------------------------------
Looks good. I see that you're creating two new configurations to set the
component type and name. These don't have a default value, but the kafka and
solr code already sets the default values, so the code will work fine.
[~coheigea] Do you think this patch makes sense? You've been doing some work on
the generic model. It looks good for me, but I'd like you opinion.
> Improve parameter handling for SentryGenericProviderBackend
> -----------------------------------------------------------
>
> Key: SENTRY-1992
> URL: https://issues.apache.org/jira/browse/SENTRY-1992
> Project: Sentry
> Issue Type: Improvement
> Reporter: Mano Kovacs
> Assignee: Mano Kovacs
> Attachments: SENTRY-1992.001.patch
>
>
> {{SentryGenericProviderBackend}} uses {{componentType}} and {{serviceName}}
> for sentry-service request but does not validate if it set, nor takes it from
> the configuration. That makes less modular to configure bindings.
> Proposing validation of the parameters and fallback for configuration entries.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
