[
https://issues.apache.org/jira/browse/SENTRY-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210970#comment-16210970
]
Mano Kovacs commented on SENTRY-2012:
-------------------------------------
I am working on the followup of SENTRY-639 (HBaseIndexer/Lily integration). I
am planning to contribute, but currently not ready for general share, so making
SentryShellGeneric extendible would be a big help for future integration.
[~coheigea], I have seen that you have a lot of refactoring lately under
SENTRY-1210 and SENTRY-1975. I was wondering what do you think about my
proposal. If you agree with this, I would prepare a patch.
* {{SentryShellGeneric}} is currently needs changes to support any other
component. I would make it extensible.
* * I would make {{GenericPrivilegeConverter}} component independent that
expects {{PrivilegeValidators}} and a new interface called
{{AuthorizableFactory}} to abstract {{*ModelAuthrizable.from(..)}} methods.
Also allow optional privilege string parser for Kafka.
* * I would make {{SentryShellGeneric}} abstract and leave create abstract
{{getServiceName}}, {{getComponent}}, {{getPrivilegeConverter}} abstract.
* I would create {{SentryShellKafka}}, {{SentryShellSolr}},
{{SentryShellSqoop}} to provide {{GenericPrivilegeConverter}} parameterized by
their own {{PrivilegeValidators}}, {{AuthrizableFactory}}, and privilege string
parser for Kafka.
> Make SentryShellGeneric extendible
> ----------------------------------
>
> Key: SENTRY-2012
> URL: https://issues.apache.org/jira/browse/SENTRY-2012
> Project: Sentry
> Issue Type: Improvement
> Reporter: Mano Kovacs
>
> SentryShellGeneric is currently has support for hardcoded components.
> Proposing a refactoring to make is extendible by external libraries.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
