[ 
https://issues.apache.org/jira/browse/SENTRY-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370284#comment-16370284
 ] 

kalyan kumar kalvagadda commented on SENTRY-1904:
-------------------------------------------------

[~akolb], I have addressed your comments and changes the retry logic as 
suggested. Please have a look when you get time.
[~spena], My latest patch addressed your comments but I see from your review 
that it is not complete and would continue reviewing it. Would be great of you 
could complete it.
Goal of this patch was to remove the retries based on count and have retry 
logic that is bounded by time.
This is done by adding limits on total time a transaction could retry and limit 
on every retry interval.
 

> TransactionManager should limit the max time spent by transaction retry
> -----------------------------------------------------------------------
>
>                 Key: SENTRY-1904
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1904
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.0.0
>            Reporter: Alexander Kolbasov
>            Assignee: kalyan kumar kalvagadda
>            Priority: Major
>         Attachments: SENTRY-1904.001.patch, SENTRY-1904.002.patch, 
> SENTRY-1904.003.patch, SENTRY-1904.004.patch, SENTRY-1904.005.patch, 
> SENTRY-1904.006.patch, SENTRY-1904.007.patch, SENTRY-1904.008.patch
>
>
> The TransactionManager uses exponential backoff strategy for transaction 
> retries. This may cause some transactions to be delayed by a very long time. 
> We should also have a constraint on the max time for a transaction so that we 
> do not retry for too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to