[
https://issues.apache.org/jira/browse/SENTRY-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391731#comment-16391731
]
kalyan kumar kalvagadda commented on SENTRY-2167:
-------------------------------------------------
[~spena] There could a lot of alter table events where neither object name and
location are updated. It should definitely not be error log. I'm not sure of
the value we can get by having with it debug level "INFO".
Regarding SentryNoSuchObjectException, from the name it looks like it is thrown
when entires are not found in sentry store.
I will check the code in sentry store to to find all the cases it is thrown.
> Fix the logs in NotificationProcessor
> -------------------------------------
>
> Key: SENTRY-2167
> URL: https://issues.apache.org/jira/browse/SENTRY-2167
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 2.1.0
> Reporter: kalyan kumar kalvagadda
> Assignee: kalyan kumar kalvagadda
> Priority: Major
>
> Log levels of the couple of log messages looks to be in-correct. This has to
> be fixed.
> Here is one of them
> {noformat}
> if ((oldDbName.equals(newDbName))
> && (oldTableName.equals(newTableName))
> && (oldLocation.equals(newLocation))) {
> LOGGER.error(String.format("Alter table notification ignored as neither name
> nor "
> + "location has changed: oldAuthzObj = %s, oldLocation = %s, newAuthzObj =
> %s, "
> + "newLocation = %s", oldDbName + "." + oldTableName, oldLocation,
> newDbName + "." + newTableName, newLocation));
> return false;
> }
> {noformat}
>
> 1. When the location and name of the object is not changed, sentry ignores
> that event. It is not an error. This should be logged with debug level.
> 2. When ever, SentryNoSuchObjectException is thrown, it is logged with INFO
> level. It is common that sentry doesn't have permissions on the objects that
> are changed. It need not be logged with INFO, instead it should be logged
> with debug level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
