[ 
https://issues.apache.org/jira/browse/SENTRY-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397177#comment-16397177
 ] 

kalyan kumar kalvagadda commented on SENTRY-2167:
-------------------------------------------------

[~spena] There could be a lot of such events where location and objects don't 
change. Do you think logging it would help? 

> Fix the logs in NotificationProcessor
> -------------------------------------
>
>                 Key: SENTRY-2167
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2167
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: kalyan kumar kalvagadda
>            Assignee: kalyan kumar kalvagadda
>            Priority: Major
>
> Log levels of the couple of log messages looks to be in-correct. This has to 
> be fixed.
> Here is one of them
> {noformat}
> if ((oldDbName.equals(newDbName))
>  && (oldTableName.equals(newTableName))
>  && (oldLocation.equals(newLocation))) {
>  LOGGER.error(String.format("Alter table notification ignored as neither name 
> nor "
>  + "location has changed: oldAuthzObj = %s, oldLocation = %s, newAuthzObj = 
> %s, "
>  + "newLocation = %s", oldDbName + "." + oldTableName, oldLocation,
>  newDbName + "." + newTableName, newLocation));
>  return false;
> }
> {noformat}
>  
> 1. When the location and name of the object is not changed, sentry ignores 
> that event. It is not an error. This should be logged with debug level.
> 2. When ever, SentryNoSuchObjectException is thrown, it is logged with INFO 
> level. It is common that sentry doesn't have permissions on the objects that 
> are changed. It need not be logged with INFO, instead it should be logged 
> with debug level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to