[
https://issues.apache.org/jira/browse/SCB-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315605#comment-16315605
]
ASF GitHub Bot commented on SCB-184:
------------------------------------
liubao68 commented on a change in pull request #492: [SCB-184]Provide starters
for Spring Cloud to using service-center and config-center
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160069412
##########
File path:
spring-boot-starter/spring-boot-starter-discovery/src/main/java/io/servicecomb/springboot/starter/discovery/CseRoutesProperties.java
##########
@@ -1,42 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package io.servicecomb.springboot.starter.discovery;
Review comment:
This class depends on ServiceComb core modules and transport modules. And it
is used to configure instances filtering, e.g. latest, 0.0.1+. But for spring
cloud applications, They do not need this features.
For spring cloud conventions, developers can use Ribbon filters or other
ways to do this. It's better not couple spring cloud users to servicecomb.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Provide starters for Spring Cloud to using service-center and config-center
> ---------------------------------------------------------------------------
>
> Key: SCB-184
> URL: https://issues.apache.org/jira/browse/SCB-184
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: liubao
>
> we have already have starters for spring cloud to using ServiceComb as a
> whole component. Now we make these components small enough to let spring
> cloud users to do the following:
> 1. provide a starter to register spring cloud application to service center;
> 2. provide a starter to using config center for dynamic configuration;
> 3. provide a starter that implments DiscoveryClient and using @Loadbalanced
> RestTemplate and using ZuulProxy
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
