[
https://issues.apache.org/jira/browse/SCB-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317506#comment-16317506
]
ASF GitHub Bot commented on SCB-184:
------------------------------------
wujimin commented on a change in pull request #492: [SCB-184]Provide starters
for Spring Cloud to using service-center and config-center
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160300628
##########
File path:
spring-boot-starter/spring-boot-starter-discovery/src/main/java/io/servicecomb/springboot/starter/discovery/ServiceCombServerList.java
##########
@@ -16,65 +16,57 @@
*/
package io.servicecomb.springboot.starter.discovery;
+import java.util.ArrayList;
import java.util.List;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import java.util.Map;
import com.netflix.client.config.IClientConfig;
import com.netflix.loadbalancer.AbstractServerList;
import com.netflix.loadbalancer.Server;
-import io.servicecomb.loadbalance.ServerListCache;
+import io.servicecomb.foundation.common.cache.VersionedCache;
+import io.servicecomb.foundation.common.net.URIEndpointObject;
+import io.servicecomb.serviceregistry.RegistryUtils;
+import io.servicecomb.serviceregistry.api.registry.MicroserviceInstance;
+import io.servicecomb.serviceregistry.definition.DefinitionConst;
+import io.servicecomb.serviceregistry.discovery.DiscoveryContext;
+import io.servicecomb.serviceregistry.discovery.DiscoveryTree;
public class ServiceCombServerList extends AbstractServerList<Server> {
- private static final Logger logger =
LoggerFactory.getLogger(ServiceCombServerList.class);
-
- private final CseRoutesProperties config;
-
- private ServerListCache serverListCache;
+ private DiscoveryTree discoveryTree = new DiscoveryTree();
private String serviceId;
- public ServiceCombServerList(CseRoutesProperties config) {
- this.config = config;
+ public ServiceCombServerList() {
}
@Override
public List<Server> getInitialListOfServers() {
- return servers();
+ DiscoveryContext context = new DiscoveryContext();
+ context.setInputParameters(serviceId);
+ VersionedCache serversVersionedCache = discoveryTree.discovery(context,
+ RegistryUtils.getAppId(),
+ serviceId,
+ DefinitionConst.VERSION_RULE_ALL);
+ Map<String, MicroserviceInstance> servers = serversVersionedCache.data();
Review comment:
extract to filter
can create new issue for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Provide starters for Spring Cloud to using service-center and config-center
> ---------------------------------------------------------------------------
>
> Key: SCB-184
> URL: https://issues.apache.org/jira/browse/SCB-184
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: liubao
>
> we have already have starters for spring cloud to using ServiceComb as a
> whole component. Now we make these components small enough to let spring
> cloud users to do the following:
> 1. provide a starter to register spring cloud application to service center;
> 2. provide a starter to using config center for dynamic configuration;
> 3. provide a starter that implments DiscoveryClient and using @Loadbalanced
> RestTemplate and using ZuulProxy
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
