[
https://issues.apache.org/jira/browse/SCB-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371036#comment-16371036
]
ASF GitHub Bot commented on SCB-327:
------------------------------------
zhengyangyong commented on a change in pull request #555: [SCB-327] Update
metrics publish data module (Re-organized)
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r169550013
##########
File path:
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/monitor/ConsumerInvocationMonitor.java
##########
@@ -17,11 +17,12 @@
package org.apache.servicecomb.metrics.core.monitor;
+import java.util.HashMap;
+import java.util.Map;
-import org.apache.servicecomb.metrics.common.ConsumerInvocationMetric;
-import org.apache.servicecomb.metrics.common.MetricsConst;
+import org.apache.servicecomb.foundation.metrics.MetricsConst;
-public class ConsumerInvocationMonitor extends InvocationMonitor {
+public class ConsumerInvocationMonitor {
Review comment:
I had use DefaultMonitorRegistry as monitor container replace it;
In order to update monitor,I had add a group of basic wrapped monitor
extends from AbstractMonitor;
Measure metrics will direct from
DefaultMonitorRegistry.getInstance().getRegisteredMonitors() then getValue()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update metrics publish data module
> ----------------------------------
>
> Key: SCB-327
> URL: https://issues.apache.org/jira/browse/SCB-327
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Change data publish from RegistryMetric model to map
> adjust metrics publish format to spring cloud netflix style
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
