[
https://issues.apache.org/jira/browse/SCB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388867#comment-16388867
]
ASF GitHub Bot commented on SCB-210:
------------------------------------
liubao68 commented on a change in pull request #569: SCB-210 remove extra
useless config item
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/569#discussion_r172183864
##########
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
##########
@@ -150,7 +151,7 @@ private static void
duplicateServiceCombConfigToCse(ConcurrentCompositeConfigura
}
public static DynamicWatchedConfiguration
createConfigFromConfigCenter(Configuration localConfiguration) {
- if (localConfiguration.getProperty(configCenterUrlKey) == null) {
+ if ((localConfiguration.getProperty(configCenterUrlKey) == null) &&
(localConfiguration.getProperties((configApolloUrlKey)) == null )) {
Review comment:
This code should be implementation independent. Can you find a better
solution if possible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use map feature to design microservice yaml file to support control flag of
> config center
> -----------------------------------------------------------------------------------------
>
> Key: SCB-210
> URL: https://issues.apache.org/jira/browse/SCB-210
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: Bo Li
> Assignee: Bo Li
> Priority: Major
>
> check comment of wujimin at:
> https://github.com/apache/incubator-servicecomb-java-chassis/pull/489/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
